fix: render selfcheck_error as no-value on empty list; document ai_energy_level level labels
This commit is contained in:
1 parent
2a0a9f32ee
commit
0cc9d8e511
2 files changed
+9
-1
No files matched your search
@@ -249,7 +249,7 @@ SELF_CHECK = Capability(
|
|||||||
entity_category='diagnostic',
|
entity_category='diagnostic',
|
||||||
exists_fn=lambda rep, resources: (
|
exists_fn=lambda rep, resources: (
|
||||||
not rep or 'x.com.samsung.da.error' in rep),
|
not rep or 'x.com.samsung.da.error' in rep),
|
||||||
value_fn=lambda v: ', '.join(v) if isinstance(v, list) else v),
|
value_fn=lambda v: (', '.join(v) if v else None) if isinstance(v, list) else v),
|
||||||
ButtonDesc(key='selfcheck_start', field='', name='Start self-check',
|
ButtonDesc(key='selfcheck_start', field='', name='Start self-check',
|
||||||
payload='Start', icon='mdi:play-circle-outline',
|
payload='Start', icon='mdi:play-circle-outline',
|
||||||
entity_category='diagnostic',
|
entity_category='diagnostic',
|
||||||
@@ -599,6 +599,8 @@ AI_ENERGY_LEVEL = Capability(
|
|||||||
href='/energy/ailevel/vs/0',
|
href='/energy/ailevel/vs/0',
|
||||||
poll_tier='cold',
|
poll_tier='cold',
|
||||||
entities=(
|
entities=(
|
||||||
|
# Only levels '1'/'2' have translated labels in strings.json/translations;
|
||||||
|
# a higher supportedAiLevel entry renders as its raw value until added.
|
||||||
SelectDesc(key='ai_energy_level', field='aiLevel',
|
SelectDesc(key='ai_energy_level', field='aiLevel',
|
||||||
name='AI energy level', icon='mdi:leaf',
|
name='AI energy level', icon='mdi:leaf',
|
||||||
translation_key='ai_energy_level',
|
translation_key='ai_energy_level',
|
||||||
|
|||||||
@@ -260,6 +260,12 @@ class TestSelfCheckError:
|
|||||||
desc = self._desc()
|
desc = self._desc()
|
||||||
assert desc.value_fn('DA_ERROR_NONE') == 'DA_ERROR_NONE'
|
assert desc.value_fn('DA_ERROR_NONE') == 'DA_ERROR_NONE'
|
||||||
|
|
||||||
|
def test_value_none_for_empty_list(self):
|
||||||
|
"""An empty error list means no value to show -- None (unknown),
|
||||||
|
not an empty string."""
|
||||||
|
desc = self._desc()
|
||||||
|
assert desc.value_fn([]) is None
|
||||||
|
|
||||||
|
|
||||||
class TestAiEnergyLevel:
|
class TestAiEnergyLevel:
|
||||||
"""AI energy-saving level select on /energy/ailevel/vs/0 -- only
|
"""AI energy-saving level select on /energy/ailevel/vs/0 -- only
|
||||||
|
|||||||
Reference in new issue
Block a user