laundry: guided setup left download cycles unselectable, and cleared the course
A program is only offerable once it has both a name and the Download course code that goes in the Course_ token. Guided setup collected names and never asked about the course, so a user could walk all nine programs, watch every name save, and end up with nothing in the cycle list. Worse, it actively cleared the course. _apply_cloud_course_names read download_course out of the submitted form; the guided name form has no such field, so it passed None and apply_cloud_courses stored that. Naming a program therefore removed every previously-named program from the list. Traced on the fixture: 87 -> name one -> None -> nothing offerable. Two changes. apply_cloud_courses now defaults download_course to "leave it alone" rather than None, so silence can't be mistaken for a clear, and the guided path forwards the field only when its form actually carried it. And the first guided name form now asks for the course, prefilled from what was just observed, dropping the field once confirmed. Asking there rather than up front is deliberate: it is the first moment there is evidence to prefill, since the user has just loaded a program and the course showing alongside it is the Download one. That makes the walk stand on its own, which is the whole point of offering it as the primary path. The bulk form's course dropdown now shares the guided one's builder. Translations for the guided-setup strings are in for cs/de/es/it/ko/nl, matching the vocabulary the earlier pass established. The new field on the name form reuses each locale's existing label from the bulk form rather than adding an untranslated string.
This commit is contained in:
10 files changed
+219
-103
No files matched your search
@@ -622,3 +622,62 @@ async def test_the_name_form_shows_the_other_names_while_typing(hass: HomeAssist
|
||||
|
||||
form = await handler.async_step_cloud_name()
|
||||
assert form["description_placeholders"]["named_list"] == "Jeans"
|
||||
|
||||
|
||||
async def test_guided_naming_never_clears_a_confirmed_download_course(hass: HomeAssistant):
|
||||
"""A program needs both a name and the Download course before it can be
|
||||
offered. The guided name form says nothing about the course, and passing
|
||||
that silence through as None wiped a confirmed one -- so naming a program
|
||||
removed every already-named program from the cycle list."""
|
||||
coordinator = await _coordinator(hass)
|
||||
coordinator.apply_cloud_courses({"6B": "Jeans"}, "87")
|
||||
await _flush(hass)
|
||||
assert "cloud:6B" in _cycle_options(coordinator)
|
||||
|
||||
handler = await _options_handler(hass, coordinator)
|
||||
await handler.async_step_cloud_guided()
|
||||
_stub_probe(coordinator, ["55"])
|
||||
await _run_wait(handler)
|
||||
await handler.async_step_cloud_name({"name": "Sports"})
|
||||
await _flush(hass)
|
||||
|
||||
assert coordinator.cloud_courses.snapshot()["download_course"] == "87"
|
||||
assert {"cloud:55", "cloud:6B"} <= set(_cycle_options(coordinator))
|
||||
|
||||
|
||||
async def test_guided_setup_alone_produces_a_selectable_cycle(hass: HomeAssistant):
|
||||
"""The walk has to stand on its own: someone who only ever uses guided
|
||||
setup must end up with something in the cycle list. So the first name
|
||||
form also asks for the Download course, prefilled from what was just
|
||||
observed, and drops the field once it is confirmed."""
|
||||
coordinator = await _coordinator(hass)
|
||||
handler = await _options_handler(hass, coordinator)
|
||||
await handler.async_step_cloud_guided()
|
||||
_stub_probe(coordinator, ["55"])
|
||||
await _run_wait(handler)
|
||||
|
||||
first = await handler.async_step_cloud_name()
|
||||
assert "download_course" in str(first["data_schema"].schema)
|
||||
# Prefilled from the observation the fixture already carries.
|
||||
assert handler._cloud_course == "87"
|
||||
|
||||
await handler.async_step_cloud_name({"name": "Sports", "download_course": "87"})
|
||||
await _flush(hass)
|
||||
assert "cloud:55" in _cycle_options(coordinator)
|
||||
|
||||
# Confirmed now, so the next program is asked for its name only.
|
||||
handler._cloud_slot = "6B"
|
||||
second = await handler.async_step_cloud_name()
|
||||
assert "download_course" not in str(second["data_schema"].schema)
|
||||
|
||||
|
||||
async def test_guided_rejects_a_download_course_the_device_does_not_offer(hass: HomeAssistant):
|
||||
coordinator = await _coordinator(hass)
|
||||
handler = await _options_handler(hass, coordinator)
|
||||
await handler.async_step_cloud_guided()
|
||||
_stub_probe(coordinator, ["55"])
|
||||
await _run_wait(handler)
|
||||
|
||||
result = await handler.async_step_cloud_name({"name": "Sports", "download_course": "FF"})
|
||||
assert result["errors"] == {"base": "cloud_course_unknown_course"}
|
||||
assert coordinator.cloud_courses.snapshot()["download_course"] is None
|
||||
Reference in new issue
Block a user