Fix C1 (switch discovery), C2 (power write_fn), I2 (golden oracle)

C1: SwitchDesc MQTT discovery now emits payload_on/off='On'/'Off',
state_on/off='On'/'Off', and a Jinja2 boolean-to-string value_template
so HA can correctly interpret and command switch entities.

C2: POWER write_fn corrected — path is ['power','vs','0'] segment list
(not a single slash-prefixed string), and payload comparison is
p == 'On' (not truthiness) so 'Off' can actually be sent.

I2: Golden regression oracle strengthened to exact equality for both
state_keys and discovery_unique_ids; prior subset-only check allowed
over-production to go undetected. Two golden tests now fail revealing
stale fixtures (dishwasher: +3 keys; refrigerator: +9 keys) — fixtures
intentionally NOT updated, human review required.
This commit is contained in:
Marc Billow committed 2026-06-30 16:32:42 -05:00
1 parent 5906aabd7c
commit 1a76bf6d47
4 files changed
+36 -5

No files matched your search

+11 -3
View File
@@ -26,6 +26,14 @@ def _new_state_and_uids(name, resources):
def test_registry_reproduces_golden_state_keys(name, ip, request):
resources = json.load(open(f'local-tools/dumps/{ip}.json'))['resources']
golden = json.loads((GOLDEN / f'{name}.json').read_text())
state_keys, _ = _new_state_and_uids(name, resources)
missing = set(golden['state_keys']) - set(state_keys)
assert not missing, f"registry missing state keys: {sorted(missing)}"
state_keys, uids = _new_state_and_uids(name, resources)
assert set(state_keys) == set(golden['state_keys']), (
f"state_keys mismatch:\n"
f" extra: {sorted(set(state_keys) - set(golden['state_keys']))}\n"
f" missing: {sorted(set(golden['state_keys']) - set(state_keys))}"
)
assert set(uids) == set(golden['discovery_unique_ids']), (
f"unique_ids mismatch:\n"
f" extra: {sorted(set(uids) - set(golden['discovery_unique_ids']))}\n"
f" missing: {sorted(set(golden['discovery_unique_ids']) - set(uids))}"
)