De-duplicate the legacy ARTIK051 AC board-generation test (#161)

capabilities/airconditioner.py's is_legacy_board() (renamed from the
private _is_legacy_board -- it's now a cross-module helper) and
climate.py's _legacy_airflow() implemented the same "does this board have
/airflow/vs/0 but no /wind/strength/vs/0" test independently, one via
literal href strings and the other via coordinator.resource() truthiness.
is_legacy_board() now uses the module's own HREF_AIRFLOW/HREF_WIND_STRENGTH
constants, and _legacy_airflow() delegates to it via a minimal two-key
presence dict (cheaper than a full last_resources snapshot copy) instead of
re-implementing the check, so the token entities and the climate card's
legacy read/write paths can't drift apart on which board generation is in
play.
This commit is contained in:
Marc Billow committed 2026-07-28 13:31:37 +00:00
1 parent c8597532b0
commit 57e06c5ccb
3 files changed
+39 -9

No files matched your search

@@ -152,7 +152,7 @@ def _option_token(rep, prefix):
return None
def _is_legacy_board(resources):
def is_legacy_board(resources):
"""True for the board generation whose airflow lives in /airflow/vs/0.
Newer families carry several of the same option tokens (Volume, Sleep,
@@ -163,13 +163,12 @@ def _is_legacy_board(resources):
/airflow/vs/0. Same test as climate.py's _legacy_airflow(), so the entities
below and the climate entity can never disagree about the generation.
"""
return ('/airflow/vs/0' in resources
and '/wind/strength/vs/0' not in resources)
return HREF_AIRFLOW in resources and HREF_WIND_STRENGTH not in resources
def _has_option_token(prefix):
return lambda rep, resources: (
_is_legacy_board(resources) and _option_token(rep, prefix) is not None)
is_legacy_board(resources) and _option_token(rep, prefix) is not None)
def _option_token_on(prefix):