Merge remote-tracking branch 'origin/main' into claude/device-support-issue-66-caztzs

tests/fixtures/golden/dishwasher.json

@@ -3,6 +3,7 @@
     "alarm_code",
     "auto_release_dry",
     "child_lock",
+    "completion_minutes",
     "cycle",
     "cycle_active",
     "delay_start_hours",

tests/fixtures/golden/dryer.json

@@ -3,6 +3,7 @@
     "alarm_code",
     "buzzer_sound",
     "child_lock",
+    "completion_minutes",
     "cycle",
     "cycle_active",
     "delay_start_hours",

tests/fixtures/golden/washer.json

@@ -5,6 +5,7 @@
     "bubble_soak",
     "buzzer_sound",
     "child_lock",
+    "completion_minutes",
     "cycle",
     "cycle_active",
     "delay_start_hours",

tests/fixtures/golden/washer_dryer_combo.json

@@ -3,6 +3,7 @@
     "alarm_code",
     "bubble_soak",
     "child_lock",
+    "completion_minutes",
     "cycle",
     "cycle_active",
     "delay_start_hours",

tests/fixtures/golden/washer_flexwash.json

@@ -2,6 +2,7 @@
   "state_keys": [
     "alarm_code",
     "child_lock",
+    "completion_minutes",
     "cycle",
     "cycle_active",
     "delay_start_hours",

tests/test_laundry_capabilities.py

@@ -4,10 +4,11 @@ from custom_components.localthings.registry.capabilities import laundry
 
 class TestCourseHelpers:
     def test_parses_edit_course_list(self):
-        raw = 'EditCourseList_1C1D211B1E29243328262722202325322F2E30662D8F96'
+        raw = 'EditCourseList_1C1D211B1E29243328262722202325322F2E30662D8F962B2A'
         assert laundry.parse_edit_course_list(raw) == [
             '1C', '1D', '21', '1B', '1E', '29', '24', '33', '28', '26', '27',
             '22', '20', '23', '25', '32', '2F', '2E', '30', '66', '2D', '8F', '96',
+            '2B', '2A'
         ]
 
     def test_parse_edit_course_list_handles_missing_or_malformed(self):

tests/test_operational_capability.py

@@ -1,3 +1,5 @@
+"""Unit tests for operational state capabilities."""
+
 from custom_components.localthings.registry.capabilities.operational import OPERATIONAL_STATE
 
 
@@ -24,6 +26,42 @@ class TestProgressPercentage:
         assert desc.rep_fn(rep) == 42
 
 
+class TestCompletionMinutes:
+    """Unit tests for completion_minutes entity."""
+
+    def test_completion_minutes_parsing(self):
+        desc = next(e for e in OPERATIONAL_STATE.entities if e.key == 'completion_minutes')
+        
+        # 1 hour 25 mins 30 secs -> 85 mins + 1 sec ceiling = 86 mins
+        rep = {'x.com.samsung.da.remainingTime': '01:25:30'}
+        assert desc.rep_fn(rep) == 86
+
+        # Exact minutes: 1 hour 30 mins 00 secs -> 90 mins
+        rep_exact = {'x.com.samsung.da.remainingTime': '01:30:00'}
+        assert desc.rep_fn(rep_exact) == 90
+
+    def test_completion_minutes_fallback_key(self):
+        desc = next(e for e in OPERATIONAL_STATE.entities if e.key == 'completion_minutes')
+        rep = {'remainingTime': '00:45:00'}
+        assert desc.rep_fn(rep) == 45
+
+    def test_completion_minutes_stale_finish_gated(self):
+        """Firmware freezes remainingTime at '00:01:00' when progress reaches 'Finish'.
+        Should return 0 to prevent stuck values."""
+        desc = next(e for e in OPERATIONAL_STATE.entities if e.key == 'completion_minutes')
+        rep = {
+            'x.com.samsung.da.progress': 'Finish',
+            'x.com.samsung.da.remainingTime': '00:01:00',
+        }
+        assert desc.rep_fn(rep) == 0
+
+    def test_completion_minutes_missing_or_invalid(self):
+        desc = next(e for e in OPERATIONAL_STATE.entities if e.key == 'completion_minutes')
+        
+        rep = {}
+        assert desc.rep_fn(rep) is None
+
+
 class TestDelayFieldFallback:
     def test_reads_delay_end_time_when_delay_start_time_absent(self):
         from custom_components.localthings.registry.capabilities.operational import OPERATIONAL_STATE
@@ -53,4 +91,4 @@ class TestDelayFieldFallback:
         desc = next(e for e in OPERATIONAL_STATE.entities if e.key == 'delay_start_hours')
         rep = {'x.com.samsung.da.delayStartTime': '00:00:00'}
         path, body = desc.write_fn(1.5, rep)
-        assert body == {'x.com.samsung.da.delayStartTime': '1:30:00'}
+        assert body == {'x.com.samsung.da.delayStartTime': '1:30:00'}