Marc Billow
e2dcc75ed5
- Fix a real bug: airconditioner.SOUND_MODE had no exists_fn, so on boards (issue #319's FAC) that never report a live 'mode' value, entity.py's default field-presence gate silently kept the select from ever registering in HA -- while adapter.flatten() (what the golden/tests read) has no such gate, so the tests passed while documenting behavior the opposite of what shipped. Gate on supportedModes' presence instead. - Add airconditioner.MDS_ABSENCE_CLEAN for the CAC-class board's /mds/absenceclean/vs/0 -- byte-identical shape to issue #319's /csi/absenceclean/vs/0, confirmed rather than guessed, closing one more of that board's documented coverage-gap hrefs. - Add missing translation state labels (all 6 languages) for edge_lighting_mode/edge_lighting_color/indicator_light_mode's raw device codes, so they render as real words instead of a raw '3000K' -> '3000 K' fallback. - Fix an orphaned comment above SOUND_MODE that actually described the unrelated DISPLAY reuse, and correct two inaccurate rationale comments: the sound/voice ignore reason claimed a distinction from SOUND_MODE that this same dump contradicts, and the /csi/* ignore block's 'same reasoning as air_purifier.COVERAGE' precedent only actually covers 1 of its 5 hrefs. - Correct the false 'no board-token match' claim in the FAC test file and golden-regression docstring -- 'FAC' is a real _BOARD_TOKEN_TO_KEY entry (for_device_by_model alone already resolves this board); add a test that actually exercises that path, which nothing previously did despite the docstring's claim. - Drop a tautological burner-slot test that only re-asserted what the golden regression test already covers via the same code path.
108 lines
4.1 KiB
Python
108 lines
4.1 KiB
Python
"""Tests for the AILP_DA-AC-FAC-02011_0000 air conditioner (issue #319).
|
|
|
|
This board resolves to the airconditioner registry two independent ways --
|
|
modelNum's 'FAC' board token (for_device_by_model) and /oic/d's
|
|
oic.d.airconditioner type (for_device_by_oic_type) agree -- and reports
|
|
several resources the sibling TP1X_DA-AC-CAC-01001 board (issue #191) left
|
|
as a documented gap: /display/vs/0 and the /settings/sound/* trio (now
|
|
shared with air_purifier.py's identical shapes), plus two genuinely new
|
|
hrefs (/csi/absenceclean/vs/0, /csi/energysaving/vs/0).
|
|
"""
|
|
|
|
from typing import cast
|
|
|
|
from custom_components.localthings.coordinator import LocalThingsCoordinator
|
|
from custom_components.localthings.entity import _is_included
|
|
from custom_components.localthings.registry.adapter import flatten
|
|
from custom_components.localthings.registry.by_type import (
|
|
for_device_by_model,
|
|
for_device_by_oic_type,
|
|
resolve,
|
|
)
|
|
from custom_components.localthings.registry.discovery import discover
|
|
from tests.conftest import _load_device
|
|
|
|
_DEVICE_TYPES = ("oic.wk.d", "oic.d.airconditioner")
|
|
|
|
|
|
class _FakeCoordinator:
|
|
"""Minimal stand-in for entity._is_included's coordinator dependency --
|
|
same shape as test_entity.py's own fake, kept local rather than shared
|
|
across test modules."""
|
|
|
|
def __init__(self, last_resources):
|
|
self.last_resources = last_resources
|
|
|
|
def canonical_resources(self, subdevice):
|
|
return self.last_resources
|
|
|
|
|
|
def _resources():
|
|
return _load_device("airconditioner_ailp_fac")
|
|
|
|
|
|
def _bound():
|
|
resources = _resources()
|
|
reg = resolve(resources, device_types=_DEVICE_TYPES)
|
|
return discover(resources, reg.capabilities, reg.pattern_capabilities), resources
|
|
|
|
|
|
def test_oic_device_type_resolves_to_airconditioner_registry():
|
|
reg = for_device_by_oic_type(_DEVICE_TYPES)
|
|
assert reg is not None and reg.name == "airconditioner"
|
|
|
|
|
|
def test_board_token_resolves_to_airconditioner_registry():
|
|
"""'FAC' is a real _BOARD_TOKEN_TO_KEY entry -- for_device_by_model
|
|
alone (no device_types) already resolves this board correctly, same as
|
|
for_device_by_oic_type above; resolve()'s device_types-agreement isn't
|
|
covering an otherwise-unreachable path."""
|
|
resources = _resources()
|
|
info = resources["/information/vs/0"]
|
|
reg = for_device_by_model(
|
|
info["x.com.samsung.da.modelNum"], info["x.com.samsung.da.description"]
|
|
)
|
|
assert reg is not None and reg.name == "airconditioner"
|
|
|
|
|
|
def test_no_unbound_hrefs():
|
|
resources = _resources()
|
|
reg = resolve(resources, device_types=_DEVICE_TYPES)
|
|
unbound = []
|
|
discover(resources, reg.capabilities, reg.pattern_capabilities, log=unbound.append)
|
|
assert unbound == []
|
|
|
|
|
|
def test_sound_mode_registers_despite_no_live_mode_value():
|
|
"""This dump has no current `mode` value yet, only supportedModes
|
|
(mute/tone/voice). entity.py's default field-presence gate would
|
|
otherwise keep the select from ever being created in HA even though
|
|
adapter.flatten() (checked below) has no such gate and would look
|
|
bound regardless -- exercise the real _is_included gate, not just
|
|
flatten(), so a regression here can't hide behind that gap again."""
|
|
bound, resources = _bound()
|
|
entity = next(b for b in bound if b.desc.key == "sound_mode")
|
|
assert entity.desc.options_field == "supportedModes"
|
|
coord = cast(LocalThingsCoordinator, _FakeCoordinator(resources))
|
|
assert _is_included(entity, coord) is True
|
|
state = flatten(bound, resources)
|
|
assert "sound_mode" in state
|
|
assert state["sound_mode"] is None
|
|
|
|
|
|
def test_absence_clean_and_energy_saving_bound():
|
|
bound, resources = _bound()
|
|
state = flatten(bound, resources)
|
|
assert state["absence_clean"] is True
|
|
assert state["energy_saving_mode"] == "Off_100"
|
|
assert state["energy_saving_state"] == "Off"
|
|
|
|
|
|
def test_sound_volume_self_gates_off_without_max_level():
|
|
"""This board's /settings/sound/volume/vs/0 reports minLevel/resolution
|
|
but no maxLevel -- air_purifier.SOUND_VOLUME's exists_fn should keep it
|
|
unbound-but-covered rather than shipping a min=0/max=0 slider."""
|
|
bound, resources = _bound()
|
|
state = flatten(bound, resources)
|
|
assert "sound_volume" not in state
|