Marc Billow
cafd7d5afa
oneUiVersion looks like the signal you'd want -- the device naming its own
type, '7.0 Dishwasher' -- and it was the first thing detection consulted. It
never earned the position:
- Only 7 of 49 fixtures report it at all.
- All 7 resolve to the same registry from their modelNum board token alone.
- No device-support issue has ever been fixed by adding a mapping for it.
Every one went through modelNum. The alias keys it needed in
_REGISTRY_BY_KEY ('airpurifier', 'air_conditioner', 'hood') were
speculative when the registries were first written and never used since.
So it bought a key-normalizing helper (_type_key), a lookup with a suffix
fallback (for_device), three alias keys, and a second config-flow step whose
only reason to exist was phrasing a sentence about oneUiVersion -- for a
signal that has never once been decisive.
Remove it from detection. It stays in diagnostics, where it's genuinely
useful: it names the firmware generation ('7.0 Air conditioner' is Tizen
Lite), which matters when triaging an issue.
Detection order was also duplicated in four places -- the coordinator, the
config flow's probe, the golden-regression harness, and the skill -- which
is how the harness and the shipped order drift apart. Collapse it into
by_type.resolve(resources), and call that everywhere.
The two "appliance type not recognized" config steps become one. They
differed only in whether they blamed a missing oneUiVersion, which is not a
distinction a user can act on, and never was.
Verified by the full suite (795 passing), including every golden regression
-- so entity output is byte-identical for all 49 device fixtures.
TestOneUiVersionIsNotConsulted locks in the premise rather than just the
outcome: for every dump that reports a oneUiVersion, the model strings alone
must still reach a registry. If a future device breaks that, the test says
so instead of the device silently losing half its entities.
Also note in requirements-dev.txt that Python 3.13 resolves the pinned
harness floor -- 3.12 and older resolve nothing and fail the whole install.
13 lines
551 B
Plaintext
13 lines
551 B
Plaintext
# Test harness — pulls in home-assistant, pytest, and pytest-socket at the
|
|
# matching versions. pip resolves the newest home-assistant your interpreter
|
|
# supports: Python 3.13 gets 0.13.316 (the floor below), 3.14 gets newer. On
|
|
# 3.12 or older nothing resolves and the whole install fails.
|
|
pytest-homeassistant-custom-component>=0.13.316
|
|
|
|
# Integration runtime deps, needed to import the component under test
|
|
# (also declared in custom_components/localthings/manifest.json).
|
|
smartthings-local>=0.1.0
|
|
cbor2>=5.4.6
|
|
pyOpenSSL>=23.0
|
|
cryptography>=41.0
|