From 16b20c651d19fa3c0a617ef8ba25a0c1642733b2 Mon Sep 17 00:00:00 2001
From: G30 <50341825+silentoplayz@users.noreply.github.com>
Date: Mon, 24 Aug 2026 07:34:30 -0400
Subject: [PATCH] fix: restore per-item retrieval settings in the model editor
 knowledge section (#27686)

---
 src/lib/components/common/Modal.svelte        |  2 +-
 .../workspace/Models/Knowledge.svelte         | 54 ++++++++++++-------
 2 files changed, 37 insertions(+), 19 deletions(-)

diff --git a/src/lib/components/common/Modal.svelte b/src/lib/components/common/Modal.svelte
index d9d5abb5b8..9d6afc534b 100644
--- a/src/lib/components/common/Modal.svelte
+++ b/src/lib/components/common/Modal.svelte
@@ -107,7 +107,7 @@
 		if (focusTrap) {
 			focusTrap.deactivate();
 		}
-		if (modalElement) {
+		if (modalElement && modalElement.parentNode === document.body) {
 			document.body.removeChild(modalElement);
 		}
 	});
diff --git a/src/lib/components/workspace/Models/Knowledge.svelte b/src/lib/components/workspace/Models/Knowledge.svelte
index 597ce0d438..6272f50df4 100644
--- a/src/lib/components/workspace/Models/Knowledge.svelte
+++ b/src/lib/components/workspace/Models/Knowledge.svelte
@@ -3,6 +3,7 @@
 	import { config, knowledge, settings, user } from '$lib/stores';
 
 	import KnowledgeSelector from './Knowledge/KnowledgeSelector.svelte';
+	import FileItemModal from '$lib/components/common/FileItemModal.svelte';
 	import Tooltip from '$lib/components/common/Tooltip.svelte';
 	import Spinner from '$lib/components/common/Spinner.svelte';
 	import ChatBubble from '$lib/components/icons/ChatBubble.svelte';
@@ -27,6 +28,9 @@
 	let filesInputElement = null;
 	let inputFiles = null;
 
+	let showItemModal = false;
+	let selectedItemIdx = null;
+
 	$: if (selectedItems === null) {
 		selectedItems = [];
 	}
@@ -143,6 +147,10 @@
 	});
 </script>
 
+{#if showItemModal && selectedItemIdx !== null && selectedItems[selectedItemIdx]}
+	<FileItemModal bind:show={showItemModal} bind:item={selectedItems[selectedItemIdx]} edit={true} />
+{/if}
+
 <input
 	bind:this={filesInputElement}
 	bind:files={inputFiles}
@@ -222,25 +230,35 @@
 						<div
 							class="flex max-w-56 items-center gap-1.5 py-0.5 pr-2 text-xs text-gray-700 dark:text-gray-200"
 						>
-							<div class="shrink-0 text-gray-500 dark:text-gray-400">
-								{#if file.status === 'uploading'}
-									<Spinner className="size-3.5" />
-								{:else if file.type === 'collection'}
-									<Database className="size-3.5" />
-								{:else if file.type === 'note'}
-									<PageEdit className="size-3.5" />
-								{:else if file.type === 'chat'}
-									<ChatBubble className="size-3.5" />
-								{:else if file.type === 'folder'}
-									<Folder className="size-3.5" />
-								{:else}
-									<DocumentPage className="size-3.5" />
-								{/if}
-							</div>
+							<button
+								type="button"
+								class="flex min-w-0 items-center gap-1.5"
+								aria-label={$i18n.t('Edit')}
+								on:click={() => {
+									selectedItemIdx = fileIdx;
+									showItemModal = true;
+								}}
+							>
+								<div class="shrink-0 text-gray-500 dark:text-gray-400">
+									{#if file.status === 'uploading'}
+										<Spinner className="size-3.5" />
+									{:else if file.type === 'collection'}
+										<Database className="size-3.5" />
+									{:else if file.type === 'note'}
+										<PageEdit className="size-3.5" />
+									{:else if file.type === 'chat'}
+										<ChatBubble className="size-3.5" />
+									{:else if file.type === 'folder'}
+										<Folder className="size-3.5" />
+									{:else}
+										<DocumentPage className="size-3.5" />
+									{/if}
+								</div>
 
-							<div class="min-w-0 truncate">
-								{file.name || file.id}
-							</div>
+								<div class="min-w-0 truncate">
+									{file.name || file.id}
+								</div>
+							</button>
 
 							{#if file.status === 'uploading'}
 								<div class="shrink-0 text-gray-400 dark:text-gray-500">