fix: prevent delete_entries_from_collection crash when file is None (#20274)
Add null check after Files.get_file_by_id() before accessing file.hash. Raises HTTP 404 instead of crashing with AttributeError when file doesn't exist.
This commit is contained in:
1 parent
46f867cda6
commit
201c38a08a
1 file changed
+5
@@ -2421,6 +2421,11 @@ def delete_entries_from_collection(
|
|||||||
try:
|
try:
|
||||||
if VECTOR_DB_CLIENT.has_collection(collection_name=form_data.collection_name):
|
if VECTOR_DB_CLIENT.has_collection(collection_name=form_data.collection_name):
|
||||||
file = Files.get_file_by_id(form_data.file_id, db=db)
|
file = Files.get_file_by_id(form_data.file_id, db=db)
|
||||||
|
if not file:
|
||||||
|
raise HTTPException(
|
||||||
|
status_code=status.HTTP_404_NOT_FOUND,
|
||||||
|
detail=ERROR_MESSAGES.NOT_FOUND,
|
||||||
|
)
|
||||||
hash = file.hash
|
hash = file.hash
|
||||||
|
|
||||||
VECTOR_DB_CLIENT.delete(
|
VECTOR_DB_CLIENT.delete(
|
||||||
|
|||||||
Reference in new issue
Block a user