perf: build info log messages lazily so raising the log level actually saves work (#27837)

Raising GLOBAL_LOG_LEVEL to WARNING buys quieter output but not less work: 241 INFO call sites interpolate their payload into an f-string before the logging call gets to drop it. The heaviest is get_doc, which logs every chunk id and metadata dict in a collection, so on the full-context retrieval path that is the entire knowledge base, once per chat request.

That one line at WARNING, CPython 3.12:

| knowledge base | payload | before   | after   |
| -------------- | ------- | -------- | ------- |
| top-k of 3     | 1.2 kB  | 3.8 us   | 0.07 us |
| 500 chunks     | 201 kB  | 583.6 us | 0.08 us |
| 5000 chunks    | 2.0 MB  | 5.8 ms   | 0.15 us |

The lazy form log.info('query_doc:result %s %s', result.ids, result.metadatas) hands the payload to record.getMessage(), which the InterceptHandler only reaches once a record has passed the level check. Output at INFO is byte-identical. Two sites that already built their message eagerly, one str concat and one % operator, move to the same lazy form.
This commit is contained in:
Classic298 authored and GitHub committed 2026-08-02 15:39:10 -05:00
1 parent 52145eede9
commit 2d18727ab8
48 files changed
+297 -247

No files matched your search

+5 -5
View File
@@ -177,7 +177,7 @@ async def process_uploaded_file(
# processing (Tools, vision models). Attempting text
# extraction causes "Timeout reached while detecting
# encoding" errors.
log.info(f'Video file detected ({content_type}), skipping text extraction')
log.info('Video file detected (%s), skipping text extraction', content_type)
await Files.update_file_data_by_id(
file_item.id,
{'status': 'completed'},
@@ -190,7 +190,7 @@ async def process_uploaded_file(
# Documents, or media files explicitly enabled for the
# configured content extraction engine.
if not content_type:
log.info(f'File type {file.content_type} is not provided, but trying to process anyway')
log.info('File type %s is not provided, but trying to process anyway', file.content_type)
await process_file(
request,
ProcessFileForm(file_id=file_item.id),
@@ -242,7 +242,7 @@ async def process_uploaded_file(
)
if not knowledge_file:
raise Exception(f'Failed to link file {file_item.id} to knowledge {knowledge_id}')
log.info(f'Linked file {file_item.id} to knowledge {knowledge_id}')
log.info('Linked file %s to knowledge %s', file_item.id, knowledge_id)
except Exception as e:
log.warning(f'Failed to link file {file_item.id} to knowledge {knowledge_id}: {e}')
raise
@@ -322,7 +322,7 @@ async def upload_file_handler(
background_tasks: Optional[BackgroundTasks] = None,
db: Optional[AsyncSession] = None,
):
log.info(f'file.content_type: {file.content_type} {process}')
log.info('file.content_type: %s %s', file.content_type, process)
if isinstance(metadata, str):
try:
@@ -868,7 +868,7 @@ async def get_html_file_content_by_id(
# Check if the file already exists in the cache
if file_path.is_file():
log.info(f'file_path: {file_path}')
log.info('file_path: %s', file_path)
return FileResponse(file_path)
else:
raise HTTPException(