fix: Fix memory leaking in MentionList.svelte (#21965)
This commit is contained in:
1 parent
e83f668107
commit
39b87d9683
1 file changed
+13
-12
@@ -98,16 +98,17 @@
|
|||||||
return onKeyDown(event);
|
return onKeyDown(event);
|
||||||
}
|
}
|
||||||
|
|
||||||
const keydownListener = (e) => {
|
onMount(() => {
|
||||||
// required to prevent the default enter behavior
|
const keydownListener = (e: KeyboardEvent) => {
|
||||||
if (e.key === 'Enter') {
|
// required to prevent the default enter behavior
|
||||||
e.preventDefault();
|
if (e.key === 'Enter') {
|
||||||
select(selectedIndex);
|
e.preventDefault();
|
||||||
}
|
select(selectedIndex);
|
||||||
};
|
}
|
||||||
|
};
|
||||||
|
|
||||||
onMount(async () => {
|
|
||||||
window.addEventListener('keydown', keydownListener);
|
window.addEventListener('keydown', keydownListener);
|
||||||
|
|
||||||
if (channelSuggestions) {
|
if (channelSuggestions) {
|
||||||
// Add a dummy channel item
|
// Add a dummy channel item
|
||||||
_channels = [
|
_channels = [
|
||||||
@@ -117,17 +118,17 @@
|
|||||||
];
|
];
|
||||||
} else {
|
} else {
|
||||||
if (userSuggestions) {
|
if (userSuggestions) {
|
||||||
await getUserList();
|
getUserList();
|
||||||
}
|
}
|
||||||
|
|
||||||
if (modelSuggestions) {
|
if (modelSuggestions) {
|
||||||
_models = [...$models.map((m) => ({ type: 'model', id: m.id, label: m.name, data: m }))];
|
_models = [...$models.map((m) => ({ type: 'model', id: m.id, label: m.name, data: m }))];
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
});
|
|
||||||
|
|
||||||
onDestroy(() => {
|
return () => {
|
||||||
window.removeEventListener('keydown', keydownListener);
|
window.removeEventListener('keydown', keydownListener);
|
||||||
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
const hasPublicReadGrant = (grants: any) =>
|
const hasPublicReadGrant = (grants: any) =>
|
||||||
|
|||||||
Reference in new issue
Block a user