perf: build debug log messages lazily so disabled debug logs cost nothing (#27834)

GLOBAL_LOG_LEVEL defaults to INFO, so every log.debug(...) in the backend is discarded, but the message is built first: 187 call sites interpolate their payload into an f-string before the logging call runs, so the work happens on every request and the result is thrown away. The worst one sits in process_chat_payload and stringifies the whole request body, full conversation history included, once per chat completion.

That one line with DEBUG disabled, CPython 3.12:

| conversation | payload | before   | after   |
| ------------ | ------- | -------- | ------- |
| 4 messages   | 1.2 kB  | 3.4 us   | 0.07 us |
| 20 messages  | 17 kB   | 24.8 us  | 0.07 us |
| 60 messages  | 123 kB  | 216.6 us | 0.07 us |

The lazy form log.debug('form_data: %s', form_data) hands the payload to record.getMessage(), which the InterceptHandler only reaches once a record has passed the level check. With DEBUG enabled the emitted lines are byte-identical, f'{x=}' sites included: those map to %r. MistralLoader._debug_log callers get the same treatment, since that wrapper already forwards *args.
This commit is contained in:
Classic298 authored and GitHub committed 2026-07-31 19:09:01 -05:00
1 parent b67804f2b6
commit 52cfb02c72
40 files changed
+198 -190

No files matched your search

@@ -338,7 +338,7 @@ class MistralLoader:
headers = {**self.headers, 'Accept': 'application/json'}
async def url_request():
self._debug_log(f'Getting signed URL for file ID: {file_id}')
self._debug_log('Getting signed URL for file ID: %s', file_id)
async with session.get(
url,
headers=headers,
@@ -450,7 +450,7 @@ class MistralLoader:
try:
async def delete_request():
self._debug_log(f'Deleting file ID: {file_id}')
self._debug_log('Deleting file ID: %s', file_id)
async with session.delete(
url=f'{self.base_url}/files/{file_id}',
headers=self.headers,
@@ -460,7 +460,7 @@ class MistralLoader:
return await self._handle_response_async(response)
await self._retry_request_async(delete_request)
self._debug_log(f'File {file_id} deleted successfully')
self._debug_log('File %s deleted successfully', file_id)
except Exception as e:
# Don't fail the entire process if cleanup fails
@@ -519,7 +519,7 @@ class MistralLoader:
if page_content is None or page_index is None:
skipped_pages += 1
self._debug_log(
f"Skipping page due to missing 'markdown' or 'index'. Data keys: {list(page_data.keys())}"
"Skipping page due to missing 'markdown' or 'index'. Data keys: %s", list(page_data.keys())
)
continue
@@ -531,7 +531,7 @@ class MistralLoader:
if not cleaned_content:
skipped_pages += 1
self._debug_log(f'Skipping empty page {page_index}')
self._debug_log('Skipping empty page %s', page_index)
continue
# Create document with optimized metadata