fix: hide chat delete actions when the chat delete permission is disabled (#27714)

The chat delete endpoints gate on chat.delete for non-admins, but none of
the UI affordances that reach them were conditioned on it, so a user
without the permission is offered controls that always fail with
"Access prohibited".

Gates every entry point on the same condition the backend enforces,
matching the existing chat.share / chat.export / chat.import gates in the
same components:

- Sidebar chat menu (ChatMenu) Delete item — also covers the Search
  modal's menu, which reuses ChatMenu
- Sidebar Shift+hover inline Delete button (ChatItem)
- Sidebar hidden #delete-chat-button keyboard-shortcut target (ChatItem)
- Chat navbar menu Delete item (Navbar/Menu)
- Search modal Shift-held inline Delete button (SearchModal)
- Settings -> Data Controls -> Delete All Chats
- Settings -> Archived Chats per-row Delete
This commit is contained in:
G30 authored and GitHub committed 2026-08-10 23:24:02 -06:00
1 parent fe62934be7
commit a3d33b4cf3
6 files changed
+83 -71

No files matched your search

+13 -11
View File
@@ -786,17 +786,19 @@
</button>
</Tooltip>
<Tooltip content={$i18n.t('Delete')}>
<button
class="self-center dark:hover:text-white transition"
on:click|stopPropagation={() => {
deleteChatHandler(chat.id);
}}
type="button"
>
<GarbageBin strokeWidth="2" />
</button>
</Tooltip>
{#if $user?.role === 'admin' || ($user?.permissions?.chat?.delete ?? true)}
<Tooltip content={$i18n.t('Delete')}>
<button
class="self-center dark:hover:text-white transition"
on:click|stopPropagation={() => {
deleteChatHandler(chat.id);
}}
type="button"
>
<GarbageBin strokeWidth="2" />
</button>
</Tooltip>
{/if}
</div>
{:else}
<div class="flex items-center">