fix(ui): guard JSON.parse(localStorage) calls with try/catch to prevent UI crashes (#25481)

This commit is contained in:
G30 authored and GitHub committed 2026-06-01 10:33:54 -07:00
1 parent bddadafa07
commit ceb1cbc009
2 files changed
+17 -6

No files matched your search

+12 -5
View File
@@ -59,6 +59,14 @@
let closedBannerIds = []; let closedBannerIds = [];
const getDismissedBannerIds = (): string[] => {
try {
return JSON.parse(localStorage.getItem('dismissedBannerIds') ?? '[]');
} catch {
return [];
}
};
let showShareChatModal = false; let showShareChatModal = false;
let showDownloadChatModal = false; let showDownloadChatModal = false;
</script> </script>
@@ -299,7 +307,7 @@
/> />
{/if} {/if}
{#each $banners.filter((b) => ![...JSON.parse(localStorage.getItem('dismissedBannerIds') ?? '[]'), ...closedBannerIds].includes(b.id)) as banner (banner.id)} {#each $banners.filter((b) => ![...getDismissedBannerIds(), ...closedBannerIds].includes(b.id)) as banner (banner.id)}
<Banner <Banner
{banner} {banner}
on:dismiss={(e) => { on:dismiss={(e) => {
@@ -309,10 +317,9 @@
localStorage.setItem( localStorage.setItem(
'dismissedBannerIds', 'dismissedBannerIds',
JSON.stringify( JSON.stringify(
[ [bannerId, ...getDismissedBannerIds()].filter((id) =>
bannerId, $banners.find((b) => b.id === id)
...JSON.parse(localStorage.getItem('dismissedBannerIds') ?? '[]') )
].filter((id) => $banners.find((b) => b.id === id))
) )
); );
} else { } else {
+5 -1
View File
@@ -973,7 +973,11 @@
if (userSettings) { if (userSettings) {
settings.set(userSettings.ui); settings.set(userSettings.ui);
} else { } else {
settings.set(JSON.parse(localStorage.getItem('settings') ?? '{}')); try {
settings.set(JSON.parse(localStorage.getItem('settings') ?? '{}'));
} catch {
settings.set({});
}
} }
setTextScale($settings?.textScale ?? 1); setTextScale($settings?.textScale ?? 1);