AC: quantize subdevice temperature writes against their own step (Opus review)

async_send_command handed write_fn/validate_fn the raw cache snapshot
(real, on-the-wire hrefs), not a subdevice-scoped view. Every other
consumer of a full resources dict (exists_fn, rep_fn, is_legacy_board,
...) reads through coordinator.canonical_resources() specifically to
avoid this; write_fn/validate_fn didn't, so on a composite AC (issue
#177) _temperature_step's resources.get(HREF_TEMP_CONTROL) saw the
master's /temperature/control/vs/0 instead of the subdevice's own
/temperature/control/vs/1, silently rounding a subdevice's 0.5-degree
write to a whole degree. The remote-control gate stays on the raw
snapshot -- /remotectrl/* is a shared, MAIN-only resource a
subdevice's owned-hrefs-only canonical view would drop entirely.

climate.py's target_temperature_step duplicated this same
read-in-order logic; pointed it at airconditioner._temperature_step
so the read and write paths can't drift again.

Also, from the same review:
- _quantize_temperature rejects non-finite floats (nan/inf survive
  float() but raise out of round()/division, escaping write_fn's
  documented None-on-bad-payload contract).
- Deduplicated the quantize-and-check block shared by the
  temperature_ocf/temperature branches of _climate_write.
- Added the /temperatures/vs/0 items[]-fallback test that was
  previously unreachable (every increment-carrying fixture also has
  /temperature/control/vs/0, which _temperature_step checks first).
- Added a coordinator-level test seeding an indexed subdevice with its
  own step, distinct from the master's, covering the fix above.
- The Towels/Bedding regression test now checks all 7 locale catalogs,
  not just English -- the bug is a code-mapping error, and
  test_every_language_mirrors_the_english_catalog only checks key
  topology, not values.
This commit is contained in:
Marc Billow committed 2026-08-09 16:25:12 +00:00
1 parent 846aefbcba
commit 676074b2f8
6 files changed
+94 -23

No files matched your search

+20
View File
@@ -181,6 +181,26 @@ def test_climate_write_preserves_half_degree_temperature_steps():
)
def test_temperature_step_falls_back_to_temps_vs_items_when_no_control_resource():
"""Isolates the /temperatures/vs/0 fallback: every fixture that carries
an increment there also carries /temperature/control/vs/0, which
_temperature_step checks first -- so without dropping that resource,
this fallback branch is never actually exercised, and reinstating the
original bug (reading the increment off /temperatures/vs/0's top level
instead of unwrapping its items[0]) would still pass every other test."""
resources = dict(_load_device("airconditioner_cac"))
del resources[airconditioner.HREF_TEMP_CONTROL]
assert airconditioner._temperature_step(resources) == 0.5
assert airconditioner._climate_write(("temperature", 24.5), {}, None, resources) == (
["temperatures", "vs", "0"],
{
"x.com.samsung.da.items": [
{"x.com.samsung.da.id": "0", "x.com.samsung.da.desired": "24.5"}
]
},
)
def test_climate_write_rounds_to_whole_degree_with_no_advertised_increment():
"""ARTIK051 boards have neither /temperature/control/vs/0 nor an
increment field on /temperatures/vs/0's item -- target_temperature_step