laundry: cite the machine_state history confirming #358's tail
The reporter's machine_state history for the same two cycles flips to idle on the exact second progress reads 'Drying' (12:08:51 and 14:01:26), which settles what the previous commits had to infer: rep_fn returns 'Idle' whenever state isn't active, so it cannot have produced that value, and the only remaining path was the ungated sticky_live_fn the bypass returned in its place. Replaying the sequence against the pre-fix path reproduces the reported Cooling, Finish, Drying, Idle exactly; the fix holds Finish through it. Comments only -- swap the inference for the observation that confirms it.
This commit is contained in:
2 files changed
+15
-11
No files matched your search
@@ -67,11 +67,14 @@ def _new_cycle_running(rep):
|
|||||||
early once a new cycle is genuinely running.
|
early once a new cycle is genuinely running.
|
||||||
|
|
||||||
Gated on `state == 'active'`, unlike _just_finished's arm condition
|
Gated on `state == 'active'`, unlike _just_finished's arm condition
|
||||||
above: issue #358's dryer replays a running stage ('Drying') for a few
|
above: issue #358's dryer resets `progress` to its course's first
|
||||||
seconds after Finish while `state` already reads idle, and a bypass
|
stage ('Drying') in the same moment `state` goes idle, ~4s before
|
||||||
keyed on the progress code alone read that tail as a new cycle and
|
settling to 'None' -- confirmed by the reporter's machine_state
|
||||||
republished it. Releasing late costs nothing -- an unreleased hold
|
history, which flips to idle on the exact second progress reads
|
||||||
still expires on its own -- so this side takes the stronger signal."""
|
'Drying', in both captured cycles. A bypass keyed on the progress
|
||||||
|
code alone read that as a new cycle and republished it. Releasing
|
||||||
|
late costs nothing -- an unreleased hold still expires on its own --
|
||||||
|
so this side takes the stronger signal."""
|
||||||
v = rep.get("x.com.samsung.da.progress")
|
v = rep.get("x.com.samsung.da.progress")
|
||||||
return _state_is_active(rep) and v is not None and v not in ("None", "Finish")
|
return _state_is_active(rep) and v is not None and v not in ("None", "Finish")
|
||||||
|
|
||||||
|
|||||||
@@ -166,12 +166,13 @@ def test_a_new_cycle_starting_overrides_the_hold():
|
|||||||
|
|
||||||
|
|
||||||
def test_a_running_stage_after_finish_does_not_break_the_hold():
|
def test_a_running_stage_after_finish_does_not_break_the_hold():
|
||||||
"""Issue #358: the reporting dryer replays a running stage after
|
"""Issue #358: the reporting dryer resets `progress` to its course's
|
||||||
Finish -- observed twice, identically, as Cooling -> +60s Finish ->
|
first stage in the same moment `state` goes idle -- observed twice,
|
||||||
+24s 'Drying' -> +4s settled, with `state` already idle throughout the
|
identically, as Cooling -> +60s Finish -> +24s 'Drying' -> +4s
|
||||||
tail. The hold must survive it, so the cycle still reads Drying,
|
settled, with the reporter's machine_state history flipping to idle on
|
||||||
Cooling, Finish, Idle rather than the reported Drying, Cooling,
|
the exact second progress reads 'Drying'. The hold must survive that,
|
||||||
Finish, Drying, Idle."""
|
so the cycle still reads Drying, Cooling, Finish, Idle rather than the
|
||||||
|
reported Drying, Cooling, Finish, Drying, Idle."""
|
||||||
desc = replace(_PROGRESS_DESC, sticky_seconds=0.2)
|
desc = replace(_PROGRESS_DESC, sticky_seconds=0.2)
|
||||||
sensor, coordinator = _sensor(desc)
|
sensor, coordinator = _sensor(desc)
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user