Fix transposed Normal/Express 60 dishwasher cycle labels (issue #226)
'83' and '86' were swapped in the dishwasher_cycle catalog. Both the original DW9000F-class fixture this table was built from and the issue #226 reporter's board share the identical DeviceType_0812, and the original fixture's own editCourseList puts the two codes back to back (positions 4-5) -- a plausible adjacent-pair transcription slip. The reporter's live confirmation (selecting 'Normal' ran the physical Express 60 program and vice versa) settles which way: '86' is Express 60, '83' is Normal. The energy-sensor part of the same issue was already resolved per the issue thread (the device genuinely doesn't report usage, so the sensor's removal was correct) -- not touched here.
This commit is contained in:
1 parent
fb5ed32b0f
commit
e89aa4bab5
7 files changed
+33
-10
No files matched your search
@@ -33,6 +33,17 @@ class TestCycleOptions:
|
||||
assert body == {"x.com.samsung.da.options": ["Course_90"]}
|
||||
|
||||
|
||||
def test_normal_and_express_60_labels_are_not_transposed():
|
||||
"""Issue #226: '83'/'86' were swapped in the shipped catalog -- '86' is
|
||||
Express 60, '83' is Normal (see dishwasher.py's CYCLE_OPTIONS comment for
|
||||
how this was confirmed)."""
|
||||
from custom_components.localthings.catalog import _ENTITY_CATALOG
|
||||
|
||||
state = _ENTITY_CATALOG["select"]["dishwasher_cycle"]["state"]
|
||||
assert state["83"] == "Normal"
|
||||
assert state["86"] == "Express 60"
|
||||
|
||||
|
||||
class TestDishwasherOptions:
|
||||
def test_storm_wash_read_and_write(self):
|
||||
desc = next(
|
||||
|
||||
Reference in new issue
Block a user